fix: # of Activities of active members change based on the time frame#792
Merged
joanagmaia merged 4 commits intolinuxfoundation:mainfrom Apr 24, 2023
Merged
fix: # of Activities of active members change based on the time frame#792joanagmaia merged 4 commits intolinuxfoundation:mainfrom
# of Activities of active members change based on the time frame#792joanagmaia merged 4 commits intolinuxfoundation:mainfrom
Conversation
Collaborator
Author
|
This PR hopefully should fix the issue #755 🍀 |
Collaborator
Author
|
Here's how it looks after the fix, and also I have manually checked the contributions of active profile to ensure it works as intended ✨ Screen.Recording.2023-04-21.at.3.24.31.PM.mov |
joanagmaia
requested changes
Apr 21, 2023
Contributor
joanagmaia
left a comment
joanagmaia
left a comment
There was a problem hiding this comment.
Thanks for the contribution! 😄
Could you update orderBy from activeDaysCount_DESC to activityCount_DESC?
That way member with higher activityCount (which is the value we are displaying) can be sorted properly
Collaborator
Author
|
@joanagmaia Oops, sorry I missed that. Now updated the PR with changes! |
joanagmaia
requested changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at b9369bf
Replaced
listmethod withlistActivemethod inactions.jsto filter and sort active members more efficiently and accurately. Part of a dashboard module refactor.
🤖 Generated by Copilot at b9369bf
Why
How
🤖 Generated by Copilot at b9369bf
listmethod ofMemberServicewithlistActivemethod to simplify query logic and measure member activity more accurately (link)Checklist ✅
Feature,Improvement, orBug.